Refactor: modify card list grid (#350)#351
Merged
Bangdayeon merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Closed
요약이 풀 요청은 pre-commit 훅과 package.json의 lint 스크립트에서 Walkthrough
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/components/basics/LinkCard/LinkCard.tsx`:
- Line 30: In LinkCard.tsx update the className on the root element: replace the
erroneous Tailwind token "flexs" with "flex" so the flex layout and "flex-col"
take effect; locate the className string in the LinkCard component and make that
single-token change.
- Around line 45-53: The Tailwind utilities used in LinkCard.tsx (aspect-94/47,
aspect-94/69, aspect-47/58, max-w-94) are not defined in the theme; update the
className strings in the LinkCard component to use Tailwind arbitrary-value
syntax (e.g., aspect-[94/47], aspect-[94/69], aspect-[47/58], max-w-[94px]) so
the aspect-ratio and max-width resolve correctly, keeping the same class
ordering and other classes (e.g., replace in the divs that currently use
aspect-94/47, aspect-94/69 and max-w-94).
Bangdayeon
force-pushed
the
refactor/#350-modify-card-list-grid
branch
from
936b11b to
35b65a4
Compare
Bangdayeon
force-pushed
the
refactor/#350-modify-card-list-grid
branch
from
35b65a4 to
801bb4e
Compare
Bangdayeon
changed the title
Contributor
|
현 PR에서 머지 후 테스트 필요한게 어떤게 있을까요 @Bangdayeon |
Member
Author
본문 수정을 못했네요. 수정했습니다. |
Bangdayeon
force-pushed
the
refactor/#350-modify-card-list-grid
branch
from
801bb4e to
45f21c0
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/app/(route)/all-link/AllLink.tsx (1)
58-69:⚠️ Potential issue | 🟡 Minor
CardList의no-scrollbar클래스가 현재 구조에서 불필요합니다.
CardList는overflow속성 없이 순수 그리드 컨테이너(grid grid-cols-2 gap-4 md:grid-cols-4)로 렌더링됩니다. 스크롤은 부모div(Line 49,overflow-y-auto)에서 처리되므로,CardList의no-scrollbar클래스는 스크롤바를 숨길 대상이 없어 효과가 없습니다.
CardList.tsx에서 하드코딩된no-scrollbar클래스는 제거하거나, 향후CardList자체가 overflow 컨테이너가 되는 경우를 대비해 조건부 적용 가능하도록prop이나variant로 변경하는 것을 권장합니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/`(route)/all-link/AllLink.tsx around lines 58 - 69, The CardList component is currently emitting a hardcoded "no-scrollbar" class which is ineffective here because scrolling is handled by the parent; open CardList.tsx and remove the hardcoded "no-scrollbar" class (or replace it with a conditional prop/variant such as hideScrollbar:boolean or variant="no-scrollbar" that toggles the class) so callers like AllLink.tsx (where CardList wraps LinkCard items) don't receive an unnecessary class; if you add a prop, update usages accordingly (e.g., remove any prop usage in AllLink.tsx) and ensure the default behavior is unchanged when the prop is omitted.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/basics/LinkCard/LinkCard.tsx`:
- Line 53: In LinkCard (the div with className "flex aspect-94/69 w-full flex-1
flex-col justify-between p-3") there is a conflict between flex-1 and
aspect-94/69 that can break height calculation; update that element in
LinkCard.tsx to use only one sizing approach—either remove "flex-1" if you want
the fixed aspect ratio ("aspect-94/69") to control height, or remove
"aspect-94/69" if you want the flex layout to allocate remaining height—then
ensure the remaining classes ("flex", "w-full", "flex-col", "justify-between",
"p-3") remain intact.
---
Outside diff comments:
In `@src/app/`(route)/all-link/AllLink.tsx:
- Around line 58-69: The CardList component is currently emitting a hardcoded
"no-scrollbar" class which is ineffective here because scrolling is handled by
the parent; open CardList.tsx and remove the hardcoded "no-scrollbar" class (or
replace it with a conditional prop/variant such as hideScrollbar:boolean or
variant="no-scrollbar" that toggles the class) so callers like AllLink.tsx
(where CardList wraps LinkCard items) don't receive an unnecessary class; if you
add a prop, update usages accordingly (e.g., remove any prop usage in
AllLink.tsx) and ensure the default behavior is unchanged when the prop is
omitted.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.husky/pre-commitpackage.jsonsrc/app/(route)/all-link/AllLink.tsxsrc/components/basics/CardList/CardList.tsxsrc/components/basics/LinkCard/LinkCard.tsxsrc/styles/globals.css
🚧 Files skipped from review as they are similar to previous changes (3)
- src/components/basics/CardList/CardList.tsx
- package.json
- .husky/pre-commit
Contributor
|
코드래빗 리뷰 확인부탁드립니다 @Bangdayeon |
Bangdayeon
force-pushed
the
refactor/#350-modify-card-list-grid
branch
from
45f21c0 to
e9cd3fa
Compare
Bangdayeon
force-pushed
the
refactor/#350-modify-card-list-grid
branch
from
e9cd3fa to
8d481f6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.husky/pre-commit:
- Line 4: The pre-commit hook currently runs "pnpm lint-staged" but package.json
has no "lint-staged" script and lint-staged is only a devDependency, so the hook
fails; either revert the hook line in .husky/pre-commit to use "pnpm exec
lint-staged" or add a "lint-staged": "lint-staged" script entry in package.json
so "pnpm run lint-staged" resolves—update the .husky/pre-commit invocation or
the package.json script accordingly to restore the hook.
ℹ️ Review info
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.husky/pre-commitpackage.jsonsrc/app/(route)/all-link/AllLink.tsxsrc/components/basics/CardList/CardList.tsxsrc/components/basics/LinkCard/LinkCard.tsxsrc/styles/globals.css
🚧 Files skipped from review as they are similar to previous changes (4)
- src/components/basics/CardList/CardList.tsx
- src/app/(route)/all-link/AllLink.tsx
- package.json
- src/components/basics/LinkCard/LinkCard.tsx
Seong-Myeong
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
PR 설명